Repository navigation
feat(online): Remember host game options between sessions - #615
Merged
x64-dev merged 1 commit intoSep 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host game popup now remembers Allow Observers, Limit Armies and Record Stats. The choices are saved when you create a game and loaded again the next time you open the popup.
Two things stopped the options from being remembered before: Allow Observers was always forced on when the popup opened, and Limit Armies was never loaded in Generals Online builds because its load code sat behind the stats-restrictions define. Both now use the saved value. First-time hosts still get observers and stats on by default.