Repository navigation
feat(online): Stabilize and redraw the lobby connection indicator - #614
Merged
x64-dev merged 2 commits intoSep 25, 2026
Conversation
tintinhamans
changed the title
x64-dev
merged commit Sep 25, 2026
e828400
into
GeneralsOnlineDevelopmentTeam:main
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lobby connection indicator was flickering a lot, so I made the score behind it more stable. It now waits 1s after connecting before showing a score, smooths the value over time, and uses rebalanced weights so one bad metric can't drag the whole score down.
I also replaced the old ping images with a custom draw. It shows a spinner while connecting, a warning triangle if the connection fails, and 5 signal bars once connected. The bars have a small buffer at each threshold so they don't jump back and forth.