Skip to content

fix: Fix D3D8 device reset and shutdown crashes - #613

Merged
x64-dev merged 6 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/render-exit-crashes
Sep 25, 2026
Merged

x64-dev merged 6 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/render-exit-crashes

Conversation

@tintinhamans

Copy link
Copy Markdown

Device reset: the device still had vertex/index buffers, textures and possibly a custom render target
bound when Reset() was called, which crashed the runtime in DestroyResource. These are now unbound
on the device and the default back buffer is restored before resetting.

Shutdown: camera shakes are now cleared when the view is destroyed, while their memory pool is still
alive, instead of in a static destructor at exit. Threads that exit after the thread list has been
destroyed no longer touch it.

Also guards a missing tint envelope in Overlord tank/truck draw and clamps tree partition indices
when a unit moves.

@x64-dev
x64-dev merged commit f208499 into GeneralsOnlineDevelopmentTeam:main Sep 25, 2026
5 checks passed
@tintinhamans
tintinhamans deleted the arctic/go/fix/render-exit-crashes branch September 25, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants