Repository navigation
fix(online): Show neutral rank icon for random and unranked-side players - #605
Merged
x64-dev merged 2 commits intoSep 25, 2026
Conversation
tintinhamans
force-pushed
the
arctic/go/fix/lobby-random-rank-icon
branch
from
September 23, 2026 23:49
dbeab66 to
ce8e367
Compare
tintinhamans
force-pushed
the
arctic/go/fix/lobby-random-rank-icon
branch
from
September 23, 2026 23:49
ce8e367 to
f3e56d8
Compare
x64-dev
merged commit Sep 25, 2026
c3e5948
into
GeneralsOnlineDevelopmentTeam:main
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #599. Some players in the lobby list had no rank icon at all.
ResolveRankIconForUser()returned no icon when the favorite side was below 2, butGetFavoriteSide()returns 0 for players who mostly play Random. Before #599 those players got the neutral rank icon, so this removes the check and letsLookupSmallRankImage()handle it like before (no rank points means no icon, anything else gets the neutral-Nicon).Also fixed rows that scroll into view while a stats batch is in flight: they were skipped until the next 4s refresh. The batch callback now requests them right away, but only users that weren't requested yet this visit, so users without stats can't cause a request loop.