feat: enhance product/banner image validation (#14) - #55
Open
JustSamuel wants to merge 1 commit into
Open
Conversation
2 tasks
SudoSOS Coverage ReportCommit: 0e77b4a
Details (changed files)
The full per-file breakdown is omitted to stay under GitHub's 65,536-character comment limit. Download the |
Coverage Report for CI Build 31797206194Coverage increased (+0.01%) to 92.216%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
XtarXyan
force-pushed
the
feature/EnhanceImageValidation
branch
from
September 5, 2026 20:23
0e77b4a to
36e3d3b
Compare
XtarXyan
force-pushed
the
feature/EnhanceImageValidation
branch
from
September 5, 2026 21:22
6c6b46d to
0dbf840
Compare
Updated commit: - moved validation check after product existence check - updated validation values - moved image-validation.ts to backend/src/helpers - disabled eslint no-shadow in the file-service.ts unit test UploadFile.mv test stub per PR review Adjusted image/banner assets and import accordingly
XtarXyan
force-pushed
the
feature/EnhanceImageValidation
branch
from
September 5, 2026 21:27
0dbf840 to
ed81dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from GEWIS/sudosos-backend#735.
This branch was already CONFLICTING against old backend develop before the monorepo move, unrelated to the port itself. The only real conflict was in
validation-errors.ts, where develop had independently addedTOS_NOT_ACCEPTEDnext to where this PR addsINVALID_IMAGE_FILE-- kept both exports.pnpm-lock.yamlneeded a regeneration (now consolidated at the repo root) to pick up the newsharpdependency this PR adds. Ran the affected test files directly (product-controller,banner-controller,file-service) to confirm sharp's image validation actually works at runtime after the lockfile regen, not just that it typechecks -- all pass.backend:buildandbackend:lintboth pass.