Skip to content

feat: Bump to C++20 and update TPLs - #4127

Merged
victorapm merged 38 commits into
developfrom
feature/paludettomag1/tpls-next
Aug 27, 2026
Merged

feat: Bump to C++20 and update TPLs#4127
victorapm merged 38 commits into
developfrom
feature/paludettomag1/tpls-next

Conversation

@victorapm

@victorapm victorapm commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  • Move minimal supported C++ standard from C++17 to C++20
  • Update TPLs (hypre 3.2.0, hypredrive, VTK 9.7, RAJA suite 2026, fmt 12) and update geos codebase accordingly
  • Add ROCm build-only (no executed tests) to CI testing
  • Bump blt to 0.7.2
  • Fix various CMake warnings
  • Fix memory leaks involving hypre's MGR

Depends on GEOS-DEV/thirdPartyLibs#361
Depends on GEOS-DEV/LvArray#356

@victorapm victorapm added the ci: run device builds Allows to run the device (CUDA/HIP) builds label Aug 21, 2026

@jafranc jafranc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @victorapm

It start having quite some patch for this or that compiler depending on the version. Would it worth having a page in the doc stating those ?

@victorapm

Copy link
Copy Markdown
Contributor Author

Thanks, Jacques! You mean the checks on the vtk version? If so, I think we can remove those and just support the path for the newest version (9.7.0)

@jafranc

jafranc commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Though VTK is bumpy in its version, I was more refering to

  • gcc12.0 giving this warning explicitly altered by flags in CMake (because of vtk IIRC)
  • clang22+ giving that warning explicitly altered

Just trying to keep an explicit track eventhough CMake handles this silently.

@victorapm
victorapm requested a review from herve-gross as a code owner August 26, 2026 03:21
@rrsettgast

Copy link
Copy Markdown
Contributor

@victorapm I merged the dependent PR's. Update the LvArray hash to LvArray/develop and you are ready to go.

@victorapm

Copy link
Copy Markdown
Contributor Author

Needs code owner reviews and we're ready to merge

@bd713 bd713 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @victorapm

@victorapm
victorapm merged commit 38fcd53 into develop Aug 27, 2026
22 checks passed
@victorapm
victorapm deleted the feature/paludettomag1/tpls-next branch August 27, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests flag: requires updated TPL(s) Needs a specific TPL PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants