feat: Bump to C++20 and update TPLs - #4127
Merged
Merged
Conversation
victorapm
requested review from
frankfeifan,
jafranc,
jhuang2601,
joshua-white,
kimtaeho07 and
tjb-ltk
as code owners
August 21, 2026 03:05
victorapm
requested review from
acitrain,
cssherman and
sframba
as code owners
August 21, 2026 10:13
jafranc
approved these changes
Aug 25, 2026
jafranc
left a comment
Contributor
There was a problem hiding this comment.
Great work @victorapm
It start having quite some patch for this or that compiler depending on the version. Would it worth having a page in the doc stating those ?
Contributor
Author
|
Thanks, Jacques! You mean the checks on the vtk version? If so, I think we can remove those and just support the path for the newest version (9.7.0) |
Contributor
|
Though VTK is bumpy in its version, I was more refering to
Just trying to keep an explicit track eventhough CMake handles this silently. |
Contributor
|
@victorapm I merged the dependent PR's. Update the LvArray hash to LvArray/develop and you are ready to go. |
Contributor
Author
|
Needs code owner reviews and we're ready to merge |
jhuang2601
approved these changes
Aug 27, 2026
rrsettgast
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on GEOS-DEV/thirdPartyLibs#361
Depends on GEOS-DEV/LvArray#356