fix: SinglePhaseWell Thermal - #4126
Open
tjb-ltk wants to merge 8 commits into
Open
Conversation
…on contribution to well system when solving well only system . These are singlephase only issues
tjb-ltk
requested review from
OmarDuran,
dkachuma,
frankfeifan,
jhuang2601 and
rrsettgast
as code owners
August 19, 2026 17:30
tjb-ltk
added
ci: run CUDA builds
ci: run integrated tests
frankfeifan
reviewed
Aug 20, 2026
Contributor
|
@dkachuma can you take a look at this PR? Thanks. |
frankfeifan
approved these changes
Aug 27, 2026
victorapm
approved these changes
Aug 27, 2026
victorapm
added
ci: run device builds
dkachuma
reviewed
Aug 28, 2026
| @@ -233,11 +233,6 @@ void CompositionalMultiphaseWell::registerWellDataOnMesh( WellElementSubRegion & | |||
| m_numComponents = fluid0.numFluidComponents(); | |||
| } | |||
| // 1 pressure + NC compositions + 1 connectionRate + temp if thermal | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // 1 pressure + NC compositions + 1 connectionRate + temp if thermal |
| } | ||
| }; | ||
|
|
||
| template< integer IS_THERMAL > |
Contributor
There was a problem hiding this comment.
Do we need this template argument? Won't it always be 1?
| getReference< real64 >( | ||
| CompositionalMultiphaseWell::viewKeyStruct::currentTotalVolRateString() )=0.0; | ||
| getReference< real64 >( CompositionalMultiphaseWell::viewKeyStruct::currentMassRateString() )=0.0; | ||
| shutEntireWell( subRegion, dofManager, localMatrix, localRhs ); |
Contributor
There was a problem hiding this comment.
Should we call resetShutInControlState after this? Looks like we were doing that before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compositional wells were correct. The code was refactored a bit to avoid duplication in matrix stamping and Dof definition