[BUGFIX] Prevent Story Mode props from resetting during fade - #7897
Merged
Hundrec merged 2 commits intoAug 21, 2026
Merged
Conversation
github-actions
Bot
added
pr: haxe
Author
|
why did the gif get all squisheddddd |
Contributor
I can see it fine |
Prevent characters from restarting to their Idle animations post confirm in the story mode menu Closes FunkinCrew#7865
immalloy
force-pushed
the
fix/7865-story-prop-fade
branch
from
August 8, 2026 21:51
3619562 to
69c303f
Compare
Author
|
updated the commit to contain a fix so non confirm props can play animations even in transitions |
4 tasks
EliteMasterEric
requested changes
Aug 10, 2026
EliteMasterEric
left a comment
EliteMasterEric
left a comment
Member
There was a problem hiding this comment.
Check the review comment I left.
Author
|
Fixed in the latest commit!! i removed the lil guard above for it |
Author
|
non-confirm props still receive events during the transition. |
EliteMasterEric
approved these changes
Aug 13, 2026
EliteMasterEric
added
status: reviewing internally
AbnormalPoof
force-pushed
the
preview/public-playtest
branch
from
August 20, 2026 03:25
401b06b to
2e7f104
Compare
Contributor
|
Not Eric accepting a PR that will not even be seen in a patch because 0.8.6 is the last patch before the menu revamps 😭 |
Author
|
😔😔😔😔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #7865
Description
When selecting a Story Mode level during player/BF prop's idle, the prop could resume its idle animation after the confirm animation finished while the screen was fading out.
The Story Menu now stops dispatching events to level props with a
'confirm'animation after a level has been selected. This prevents beat and update events from restarting prop animations during the transition, while allowing the confirmation to play normally.Screenshots/Videos