Repository navigation
fix: restore audit pins and bun 1.4 test preload - #288
Merged
Merged
Conversation
15 of 16 tasks
FrkAk
marked this pull request as ready for review
August 25, 2026 19:11
bun audit newly fails on two high advisories in transitive dependencies: js-yaml 4.3.0 via @eslint/eslintrc (GHSA-5p4m-2wfm-xmqj) and nanoid 3.3.16 via postcss (GHSA-2v37-7h3g-55p8). Both parents declare ranges that already allow the fixed versions, so these overrides only raise the floor, following the existing documented security-pin pattern. Remove each once its parent ships the fix.
Bun 1.4 rejects Object.defineProperty on process.env unless the descriptor is configurable, enumerable, and writable; the NODE_ENV pins in the test preload and per-test helpers passed only configurable, so on CI (setup-bun@v2 floats to latest) every test file dies in preload. This was masked until now by the audit step failing first.
FrkAk
force-pushed
the
fix/audit-lockfile-bump
branch
from
August 25, 2026 19:26
0a4a1e0 to
9f29d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task Reference: None
CI's
checkjob is red on every branch for two independent, mutually masking reasons; this PR fixes both (neither can go green in a separate PR, since each failure hides or blocks the other in the same job):bun audit --audit-level=highnewly fails: two high advisories landed in transitive dependencies — js-yaml 4.3.0 via@eslint/eslintrc(GHSA-5p4m-2wfm-xmqj) and nanoid 3.3.16 viapostcss(GHSA-2v37-7h3g-55p8). Both are added to the existing documented security-pinoverridesblock; both parents declare ranges that already allow the fixed versions, so the pins only raise the floor.setup-bun@v2) rejectsObject.defineProperty(process.env, …)unless the descriptor is configurable, enumerable, AND writable. The NODE_ENV pins intests/setup/preload.tsand the per-test helpers passed onlyconfigurable, so every test file dies in preload on CI. This was masked by the audit step failing first.Type of change
Testing
bun run lint)bun run typecheck)bun audit --audit-level=high --ignore=GHSA-f88m-g3jw-g9cjexits 0 with the pins in placebun test: 2,264 of 2,265 pass — the single failure (tests/graph/tools-write.test.ts"edit set tags fires variant and taxonomy hints") reproduces identically on cleanmainin full-suite order and passes in isolation, so it is a pre-existing order dependency, not introduced here; flagged for a follow-up.Notes for reviewer
//overridesremoval note is extended in the block's existing style.definePropertysites (preload,tests/api/error.test.ts,tests/db/request-scope.workers.test.ts) and documents the bun ≥ 1.4 constraint where the pattern is defined.Docs impact
None.
Compliance impact
None.