Add MCP tool to delete a notification - #8683
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8683 +/- ##
=======================================
Coverage 77.77% 77.78%
=======================================
Files 474 474
Lines 25530 25535 +5
Branches 6798 6799 +1
=======================================
+ Hits 19857 19862 +5
Misses 5673 5673
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The id went straight into the inject URL, which resolves dot segments, so a notificationId like ../../applications/<id> deleted an application. The handler now refuses anything that is not a hashid before making the request.
andypalmi
approved these changes
Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7704
Adds
platform_delete_notification, which deletes one of the caller's own notifications.It's marked destructive, so it's served as a delete tool and read-only tokens can't reach it. The route only ever looks at the caller's own notifications, so someone else's id just gets a 404.
There's no bulk delete route (the "delete all" one is commented out), so the tool takes one id per call and the description says so. It also points the agent at marking it read if the user only wants to dismiss it.