Skip to content

Revert mqtt 5.16.0 - #8679

Merged
hardillb merged 3 commits into
mainfrom
revert-mqttjs-update
Sep 29, 2026
Merged

hardillb merged 3 commits into
mainfrom
revert-mqttjs-update

Conversation

@hardillb

Copy link
Copy Markdown
Contributor

Description

This was preventing the client from ever reconnecting

opened mqttjs/MQTT.js#2072 with upstream

Related Issue(s)

discovered locally

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

This was preventing the client from ever reconnecting

opened mqttjs/MQTT.js#2072 with upstream
@hardillb hardillb self-assigned this Sep 29, 2026
@hardillb
hardillb enabled auto-merge (squash) September 29, 2026 09:55
Comment thread package-lock.json Outdated
"lru-cache": "^11.1.0",
"marked": "^18.0.5",
"mqtt": "^5.1.1",
"mqtt": "^5.15.2",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin exact for now rather than use ^ ?

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.50%. Comparing base (daa2133) to head (1c9f6b3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8679   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files         469      469           
  Lines       25356    25356           
  Branches     6754     6754           
=======================================
  Hits        19652    19652           
  Misses       5704     5704           
Flag Coverage Δ
backend 77.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb
hardillb disabled auto-merge September 29, 2026 10:07
@hardillb
hardillb enabled auto-merge (squash) September 29, 2026 10:15
@hardillb
hardillb merged commit d8f0a7f into main Sep 29, 2026
28 checks passed
@hardillb
hardillb deleted the revert-mqttjs-update branch September 29, 2026 10:31

This branch was successfully deployed

1 active deployment
staging — 1c9f6b34 Deployed Sep 29, 2026 by hardillb via Remove application #11958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants