fix: let the MCP consent page scroll when the team list is long - #8472
Merged
Merged
Conversation
On /account/request/:id/mcp the Specific teams list could grow taller than the viewport, pushing the Deny and Allow buttons off screen so consent could not be completed. Opt this route into the existing ff--center-box modifier via route meta so the page scrolls, leaving the other modal pages unchanged. Closes #8453
andypalmi
force-pushed
the
fix/8453-mcp-consent-scroll
branch
from
September 10, 2026 13:17
60b3497 to
282fc39
Compare
andypalmi
changed the title
andypalmi
enabled auto-merge (squash)
September 10, 2026 13:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8472 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 460 460
Lines 24741 24741
Branches 6596 6596
=======================================
Hits 19022 19022
Misses 5719 5719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
approved these changes
Sep 10, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
/account/request/:id/mcpthe Specific teams list could grow past the viewport, pushing the Deny and Allow buttons off screen so consent could not be completed. This opts just that route into the existingff--center-boxmodifier viameta.centerBoxso the page scrolls, leaving the other modal pages unchanged.Closes #8453