Log fixes - #70
Merged
Merged
Conversation
Fexty12573
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue addressed here is the first log message wouldn't be included in the log file. This was because the initial state of
s_filewhen evaluated as a boolean returns true. Checkingif (!s_file)to consider opening the file only passed after the first attempted write fails ands_fileis put in a error state.The other fix is to not return on an error in
log_raw(), instead handle the potential error state when deciding whether to write to the file/console or not.Also, I added a warning that if
logLevelis invalid, Stracker's Loader will crash the game when loaded.