Skip to content

chore(ci): drop the French comments from the workflows - #248

Merged
BryanFRD merged 1 commit into
mainfrom
chore/english-workflow-comments
Sep 5, 2026
Merged

chore(ci): drop the French comments from the workflows#248
BryanFRD merged 1 commit into
mainfrom
chore/english-workflow-comments

Conversation

@BryanFRD

@BryanFRD BryanFRD commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Removes the French comment blocks from this repository's GitHub Actions workflows: 1 file(s), 8 lines.

Deletion rather than translation, per the decision on the tracking issue. The org rule is that everything is written in English, and the code-comment rule is that comments do not belong in the first place, so the two point the same way here.

Detection was calibrated rather than eyeballed. A block counts as French on one elision (d', l', qu') or two French function words. Accents were deliberately demoted to corroborating evidence only, because several files carry mojibake (UTF-8 decoded as Latin-1) that puts accented characters inside perfectly English comments; scoring on accents alone flagged an entirely English block in UI. Inline trailing comments such as # zizmor: ignore[...] are untouched, since only whole-line blocks are considered.

Ref FerrLabs/.github#316

@BryanFRD
BryanFRD enabled auto-merge (squash) September 5, 2026 10:37

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment-only deletion, YAML unchanged and still valid. The pull_request_target trigger, the zizmor ignore and the permissions block all survive intact, so behaviour is identical.

Nit: the first deleted block was the written justification for # zizmor: ignore[dangerous-triggers] — that the called workflow never checks out PR code and only reads the title from the event payload. The suppression now stands with no stated reason, and the next person auditing this file has to re-derive the safety argument. The org rule is what it is and this is a deliberate deletion rather than translation, so I'm not blocking on it, but that particular argument is worth parking somewhere durable (FerrLabs/.github#316, or the reusable workflow's own docs) rather than losing it.

@BryanFRD
BryanFRD merged commit 2d222a1 into main Sep 5, 2026
16 checks passed
@BryanFRD
BryanFRD deleted the chore/english-workflow-comments branch September 5, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant