Repository navigation
chore(lint): use the shared config's turbo, tooling wiring and import policy - #140
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…to turbo The package shape was never checked before a release. prepublishOnly now runs publint and attw, and the repository URL uses the git+ form publint asks for. The public test script now delegates to turbo like the others, the redundant test:run script is gone, and vitest in watch mode moves to test:watch, which CONTRIBUTING already referred to.
The tasks read tsconfig.build.json and tsconfig.lint.json through tsc but listed only tsconfig.json as an input, so editing either restored a stale cached result.
The thresholds sat under a global key vitest does not read, so they enforced nothing, and the exclude list used bare directory names that miss nested copies. The floors are the measured coverage rounded down, and the excludes match at any depth.
… policy Turns on the turbo script and cache rules, the publish-time tooling checks and hooks check, and an import policy that keeps test helpers out of shipped code. The root tooling check is off because it cannot hold together with the turbo convention for knip.
597f7e2 to
2817540
Compare
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
🎉 This PR is included in version 1.41.4 🎉 The release is available on:
Installationnpm install -g markmv@1.41.4Security & Supply Chain✅ OIDC Trusted Publishing: published from CI with no long-lived npm token Test CoverageThis release includes comprehensive test coverage reports. View coverage details in the release assets. Your semantic-release bot 📦🚀 |
1 participant
Turning on the options @exadev/eslint-config already offers found real problems, fixed in this PR as separate commits:
The shared config's root tooling check cannot hold together with the turbo script convention for knip, so it is off with the reason in the config; reported as ExaDev/eslint-config#110.