Repository navigation
Preserve inherited fonts and spacing in Office document PDF export - #2669
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7ef5570b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PrzemyslawKlys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word templates with an existing
docDefaultsbut no declared ordinary font size were exported at 11 pt, which could make bold, right-aligned labels cross a cell border. PDF export now follows the independently verified Word fallback: 10 pt for size-less defaults and 12 pt whendocDefaultsis absent. Explicit sizes, including half points, remain exact.Inherited table and conditional styles now use their final font size and family for relative spacing, rendering, and font registration. Complex-script size and selection remain separate from ordinary text and inherit through the supported paragraph, character, table and conditional style chains. Shared Word, Excel and PowerPoint font diagnostics distinguish resource-policy restrictions from unavailable fonts.
Validation: 682 Word PDF tests pass on both .NET 10 and .NET Framework 4.7.2; focused Excel and PowerPoint font tests pass. A 36-PDF Windows matrix covers source conversion and rebuilt PowerShell 7/5.1 payloads, with Microsoft Word exports as an independent fallback-size reference. Artifact checks cover half-point sizes, paragraph spacing, underlined spaces, synthetic italics, and label containment. Full Word page-layout equivalence is not claimed.
PSWriteOffice PR #218 documents the existing font-permission switches and report capture API. Delivering these engine fixes through a public PowerShell module requires publishing OfficeIMO, then updating the PSWriteOffice dependency and rebuilding both payloads.