fix(cascade): repair knowledge topic SQLite parity#343
Draft
SiyaoZheng wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the SQLite side of a knowledge-topic cascade write when LanceDB already contains the current content hash.
The handler writes each knowledge topic to both LanceDB and SQLite. If the LanceDB upsert succeeds but the SQLite upsert fails, the retry currently sees the matching LanceDB digest and skips the topic forever. That leaves SQLite missing or stale even though the cascade row is retried.
This change builds the SQLite payload before the digest fast path, verifies that the corresponding SQLite row exists and matches, and repairs only the SQLite side when necessary. The normal unchanged-topic path remains a no-op.
Area
Verification
Checklist
main..envfiles, dependency folders, or generated output.Notes for Reviewers
The regression test covers both a missing SQLite row and a stale SQLite row while LanceDB already has the matching digest.
By submitting this pull request, I agree that my contribution is licensed under the Apache License 2.0.