Conversation
set_daemon_interface() left ops.input and ops.update uninitialized. On some builds that produced a NULL ops.input, causing ui_register() to hit BUG_IF() and abort daemon mode with "ops->input == NULL". Set both to no-op callbacks so the daemon interface is fully populated. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Member
|
👍 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_daemon_interface()insrc/interfaces/daemon/ec_daemon.cleftops.inputandops.updateuninitialized. Whenops.inputhappened to be NULL,ui_register()hitBUG_IF(ops->input == NULL)andettercap -Dfailed with:Fix
Add no-op
daemon_input()anddaemon_update()callbacks and register them, so the daemonui_opsis fully populated.Test plan
cmake --build build -jsucceeds.ettercap -hstill works.-D/--daemonpath no longer relies on uninitialized stack values.Closes #719
Generated with Devin