Fix build for Adventure 5 and bump dependencies#142
Open
Jakubk15 wants to merge 1 commit into
Open
Conversation
The Adventure 5 upgrade removed Audience#sendMessage(Identity, Component, MessageType), which broke multification-core test compilation. Override the remaining sendMessage(Component) overload in AudienceMock instead. Apply the pending Renovate dependency bumps: - Adventure API 5.0.1 -> 5.1.1 (#137) - JUnit 6.0.3 -> 6.1.0 (#138) - Gradle wrapper 9.5.0 -> 9.6.0 (#140) - actions/checkout v6 -> v7 (#139) - gradle/actions/setup-gradle v5 -> v6 (#132) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ErZ6cWq2LVW35c7JA8S13C
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates dependency versions in Versions.kt (Adventure API to 5.1.1 and JUnit Jupiter to 6.1.0) and upgrades the Gradle wrapper to version 9.6.0. Additionally, it refactors AudienceMock.java by removing unused imports and updating the sendMessage method signature to match the simplified interface. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the broken
./gradlew buildand applies the pending Renovate dependency bumps.Why the build was broken
The Adventure 5 upgrade removed
Audience#sendMessage(Identity, Component, MessageType), butAudienceMock(inmultification-coretests) still@Override-d that now-nonexistent signature and imported the deletedMessageType/Identitytypes. This failed:multification-core:compileTestJava.The mock now overrides the surviving
sendMessage(Component)overload — which is exactly what production calls inChatResolver— so it still captures messages correctly.Dependency bumps (from open PRs)
Deliberately left out
paper-apiv26 (dependency: Update dependency io.papermc.paper:paper-api to v26 #135) — major-version jump that likely needs code/target changes; out of scope for a green-build fix.Verification
./gradlew clean buildis BUILD SUCCESSFUL on Gradle 9.6.0 — all modules compile andmultification-coretests run.🤖 Generated with Claude Code