Skip to content

Implement MiniscriptKey for each variant of DescriptorPublicKey#100

Merged
apoelstra merged 1 commit into
ElementsProject:masterfrom
Velnbur:feature/miniscript-key-for-each-descriptor-key-variant
Jun 22, 2026
Merged

Implement MiniscriptKey for each variant of DescriptorPublicKey#100
apoelstra merged 1 commit into
ElementsProject:masterfrom
Velnbur:feature/miniscript-key-for-each-descriptor-key-variant

Conversation

@Velnbur

@Velnbur Velnbur commented May 3, 2026

Copy link
Copy Markdown
Contributor

The same as rust-bitcoin/rust-miniscript#938 but for elements

@apoelstra

Copy link
Copy Markdown
Member

utACK -- heads up we may need to first port ElementsProject/rust-elements#266 and ElementsProject/rust-elements#269 to get our tooling up to date here. (Though tentatively it looks like things are working.)

@apoelstra

Copy link
Copy Markdown
Member

I'm also failing to pass the elementsd-tests tests on my local CI box. I am getting

---- test_arith stdout ----

thread 'test_arith' (50) panicked at tests/setup/mod.rs:76:48:
called `Result::unwrap()` on an `Err` value: JsonRpc(Transport(SocketError(Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" })))
stack backtrace:

With elementsd 23. IIRC there is some fairly simple change we need to make to fix our tests for a more recent elements.

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2a852f2; successfully ran local tests

@apoelstra apoelstra merged commit 80dc985 into ElementsProject:master Jun 22, 2026
9 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants