Repository navigation
Re-check files the replica listings disagree on before reporting them - #13808
Merged
skettkepalli merged 1 commit intoOct 6, 2026
Merged
skettkepalli merged 1 commit into
skettkepalli merged 1 commit into
Conversation
Signed-off-by: skettkepalli <sridhar.ettkepalli@eclipse-foundation.org>
manpreetkaur-arch
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replica check compares two bucket listings that are taken minutes apart. When an extension is deleted in between, its files are still in the source listing but already gone from the copy, so the check reports them as missing and alerts, although both buckets are identical.
Files the listings disagree on are now checked again directly against S3: a file that no longer exists in the source was deleted, and one with the same ETag on both sides has caught up. Anything else, including a permission error, more than recheckMax files, or a bucket that does not answer, is still reported, and the names of files still missing go to the pod log.
This only changes the check job. It was tested in the job's image against a real case where 18 files of a deleted extension were reported missing, and against controls for a file missing from the copy and an unreachable bucket.
Signed-off-by: skettkepalli sridhar.ettkepalli@eclipse-foundation.org