Skip to content

Maniacs Patch - ChangePictureId command + Pictures Inspector#3500

Open
jetrotal wants to merge 4 commits into
EasyRPG:masterfrom
EasyRPG-NewFeatures:maniacs/setPictureID
Open

Maniacs Patch - ChangePictureId command + Pictures Inspector#3500
jetrotal wants to merge 4 commits into
EasyRPG:masterfrom
EasyRPG-NewFeatures:maniacs/setPictureID

Conversation

@jetrotal

@jetrotal jetrotal commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

Had to put those two together because I needed one to test another

Change Picture command:

Added support for the Maniac Patch ChangePictureId event command, enabling move, swap, and slide operations on picture IDs with error handling and sprite refresh logic. This replaces the previous stub implementation and ensures proper picture management for Maniac Patch compatibility.

Map for testing the command:
Map0003.zip


Pictures Inspector:

Introduces a new debug scene and windows for viewing and inspecting active pictures and string windows. Updates scene and debug menu logic to support the new 'DebugPicture' scene, adds menu option, and implements detailed property display for both image and string pictures.

image

Added support for the Maniac Patch ChangePictureId event command, enabling move, swap, and slide operations on picture IDs with error handling and sprite refresh logic. This replaces the previous stub implementation and ensures proper picture management for Maniac Patch compatibility.
Introduces a new debug scene and windows for viewing and inspecting active pictures and string windows. Updates scene and debug menu logic to support the new 'DebugPicture' scene, adds menu option, and implements detailed property display for both image and string pictures.
@Ghabry

Ghabry commented Dec 14, 2025

Copy link
Copy Markdown
Member

Imo it would be better to have Replace(int src_id, target_id) (replaces source pic with target pic) and Swap(int first_id, int second_id) added to Game_Pictures so that most of the complex logic is not inside the interpreter.

@Ghabry Ghabry added the Needs feedback Waiting for the issue author to give further information. label Dec 24, 2025
@Ghabry
Ghabry force-pushed the maniacs/setPictureID branch from f0cc536 to 1936d1d Compare July 13, 2026 00:26
@Ghabry Ghabry removed the Needs feedback Waiting for the issue author to give further information. label Jul 13, 2026
@Ghabry
Ghabry force-pushed the maniacs/setPictureID branch from 1936d1d to abf90ed Compare July 13, 2026 00:31
Ghabry added 2 commits July 13, 2026 02:33
@Ghabry
Ghabry force-pushed the maniacs/setPictureID branch from abf90ed to b315343 Compare July 13, 2026 00:33
@Ghabry

Ghabry commented Jul 13, 2026

Copy link
Copy Markdown
Member

The code actually looks fine to me. Only:

  1. integrated the Picture Inspector better in the existing Debug UI
  2. extracted these complex lambda functions into methods in the Picture class

Only have to test it g

@Ghabry Ghabry added this to the 0.8.2 milestone Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants