fix: сохранение результатов постранично перед пометкой просмотренными (fixes #300) - #331
Open
eminsk wants to merge 1 commit into
Open
fix: сохранение результатов постранично перед пометкой просмотренными (fixes #300)#331eminsk wants to merge 1 commit into
eminsk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема (fixes #300)
В текущей версии объявления помечаются просмотренными в базе данных SQLite (
__save_viewed) сразу на каждой странице, а сохранение в файл (result_storage.save) вызывается только один раз в самом конце, после завершения цикла по всем страницам ссылки:count > 1) на последующих страницах происходит сетевая ошибка, блокировка 429 или пользователь нажимает «Стоп», функцияparse()прерывается, иresult_storage.save()не вызывается.Решение
self.result_storage.save(filtered_ads)перенесено внутрь цикла по страницам передself.__save_viewed(ads=filtered_ads).tests/test_page_save.py, проверяющий сохранение при сбоях и строгий порядок операций.