Skip to content

Correct the empty-group and lighthouse TXT notes - #414

Open
jasikpark wants to merge 2 commits into
mainfrom
empty-group-txt-notes
Open

jasikpark wants to merge 2 commits into
mainfrom
empty-group-txt-notes

Conversation

@jasikpark

Copy link
Copy Markdown
Member

John's two non-blocking notes from #390.

  • firewall.mdx: an empty list (groups: []) or empty string (group: '') never makes it into the rule's groups, so on its own the rule is rejected at load. It only loads, and matches any host, when it also sets local_cidr, ca_name, or ca_sha.
  • lighthouse.mdx, using-lighthouse-dns: a TXT query from a non-local host gets NOERROR with an empty answer, not no response.

🤖 Generated with Claude Code

An empty group list or string never reaches the rule's groups, so a rule
with nothing else is rejected at load; it only loads, matching any host,
when it also sets local_cidr, ca_name, or ca_sha. A TXT query from a
non-local host gets NOERROR with no answers rather than no response.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-nebula ready!

Name Link
🔨 Latest commit 7aa1fbd
🔍 Latest deploy log https://github.com/DefinedNet/nebula-docs/actions/runs/43293241151
😎 Deploy Preview Url https://fdfc4747.docs-nebula.pages.dev
😎 Deploy Preview Alias https://empty-group-txt-notes.docs-nebula.pages.dev

@jasikpark
jasikpark enabled auto-merge (squash) November 12, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant