Repository navigation
fix: coordinate refresh token persistence - #9
Merged
Merged
Conversation
ElgoogUdiab
marked this pull request as ready for review
September 23, 2026 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent account and MCP commands can rotate the same saved refresh token, and a read-only sandbox can consume a token without saving its replacement. This change verifies credential-store writes before issuance and coordinates refresh and persistence across CLI processes.
proper-lockfiledirectory lock on Linux, macOS, and Windows. Reload credentials under the lock, reuse a newer valid token, and keep the lock until the response is consumed and the rotated credentials are atomically saved.Validation: all 52 tests, lint, formatting, types, and packed installation checks pass locally. Installation checks cover npm global/local/one-off execution, pnpm 10, and Yarn Classic. CI runs the same checks on Linux, macOS, and Windows with Node.js 22 and 24.
Companion backend recovery: https://github.com/DeemosTech/hyper3d-backend/pull/541. Local locking does not recover a response lost after server-side rotation; no automatic network or business-operation retry is introduced. Older CLI versions sharing the credential directory do not participate in the locking protocol.