Conversation
…ream-only workflows Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c60f0c90-651f-4e64-95bf-16329ff0f3c7) |
|
Welcome to Cal.diy, JOY (@JOY)! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive architecture guide (docs/Architecture.md) and a corresponding changelog (CHANGELOG.md) detailing the adoption of a 2-tier hybrid architecture, centralized OIDC authentication via DOS ID, and automated branding pipelines. Feedback on the documentation highlights discrepancies between the documented webhook events and their actual implementation, specifically pointing out missing and unimplemented events.
| 4. **Đồng bộ Thời gian thực qua Webhook (Event-Driven Webhook Sync)**: | ||
| - Endpoint: `/api/webhooks/dos-org-sync` tiếp nhận các sự kiện được ký HMAC-SHA256: | ||
| - `organization.created` / `org.created` | ||
| - `organization.updated` / `org.updated` | ||
| - `organization.deleted` / `org.deleted` | ||
| - `organization.member_added` / `org.member_added` | ||
| - `organization.member_removed` / `org.member_removed` | ||
| - `user.updated` |
There was a problem hiding this comment.
There are a few discrepancies between this documentation and the actual webhook implementation in apps/web/app/api/webhooks/dos-org-sync/route.ts:
- Missing Events: The events
organization.member.addedandorganization.member.removed(using dot notation) are supported in the webhook handler but are not documented here. - Unimplemented Event: The
user.updatedevent is listed here, but it is currently not handled in the webhook'sswitchstatement (it falls through to thedefaultcase and is ignored).
Let's update the documentation to accurately reflect the implemented events.
| 4. **Đồng bộ Thời gian thực qua Webhook (Event-Driven Webhook Sync)**: | |
| - Endpoint: `/api/webhooks/dos-org-sync` tiếp nhận các sự kiện được ký HMAC-SHA256: | |
| - `organization.created` / `org.created` | |
| - `organization.updated` / `org.updated` | |
| - `organization.deleted` / `org.deleted` | |
| - `organization.member_added` / `org.member_added` | |
| - `organization.member_removed` / `org.member_removed` | |
| - `user.updated` | |
| 4. **Đồng bộ Thời gian thực qua Webhook (Event-Driven Webhook Sync)**: | |
| - Endpoint: `/api/webhooks/dos-org-sync` tiếp nhận các sự kiện được ký HMAC-SHA256: | |
| - `organization.created` / `org.created` | |
| - `organization.updated` / `org.updated` | |
| - `organization.deleted` / `org.deleted` | |
| - `organization.member_added` / `organization.member.added` / `org.member_added` | |
| - `organization.member_removed` / `organization.member.removed` / `org.member_removed` |
Summary
elease-docker.yaml) with if: github.repository == 'calcom/cal.diy' to eliminate failed CI notifications on fork repo.
Test plan
Note
Low Risk
Changes are documentation plus workflow
ifguards; no application runtime or auth logic is modified in this diff.Overview
Adds Crove Cal v2.0.0 documentation: a new
CHANGELOG.mdrelease notes entry anddocs/Architecture.mddescribing the 2-tier hybrid model (DOS ID / webhook org sync + MCP agent actions), OIDC integration, and branding/fork maintenance practices.CI fork safety: upstream-only GitHub Actions jobs now skip unless
github.repository == 'calcom/cal.diy'incleanup-report,cleanup,draft-release,post-release, andrelease-docker(preparejob). The i18n workflow combines that check with the existing Lingo API key guard so automation does not run (or fail) on fork repos.Reviewed by Cursor Bugbot for commit 1b41043. Bugbot is set up for automated code reviews on this repo. Configure here.