Remove Really disband squad and Really change recenter location - #1610
Open
magnus-ISU wants to merge 1 commit into
Open
Remove Really disband squad and Really change recenter location#1610magnus-ISU wants to merge 1 commit into
Really disband squad and Really change recenter location#1610magnus-ISU wants to merge 1 commit into
Conversation
DF asks 'Really disband?' when you disband a squad, and 'Really overwrite' when you reassign a recenter hotkey, so squad-disband and hotkey-reset put a second dialog in front of the game's own. Both strings are in the v53 executable beside the buttons that raise them. One nuance worth a reviewer's eye: the vanilla prompt covers overwriting a recenter hotkey, and I could not find an equivalent for CLEARING one -- the hotkey-reset spec covered both. If the clear case is worth keeping, this should narrow the predicate rather than remove the spec.
chdoc
approved these changes
Sep 5, 2026
chdoc
left a comment
chdoc
left a comment
Member
There was a problem hiding this comment.
I can confirm that the game now asks before disbanding a squad or reassigning a hotkey. So these are indeed no longer necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DF asks 'Really disband?' when you disband a squad, and 'Really overwrite' when you reassign a recenter hotkey, so squad-disband and hotkey-reset put a second dialog in front of the game's own.
This is probably one of the only cases DFhack makes the game worse, likely because it used to be necessary and no one revisited this code.