Repository navigation
Tighten the mkdir app-structure check and stop calling samples production apps - #155
Merged
Merged
Conversation
The CLI guard and test-skill.sh matched mkdir.*(api-integrations|...) against the whole command line, so 'mkdir -p /tmp/spec && python3 skills/api-integrations/scripts/adapt_spec_for_foundry.py ...' was flagged as manual app scaffolding. Both patterns now stop at ;, &, or |, so only the mkdir's own arguments count.
Foundry Skills Eval Results5/5 evals passed (100%) · model
Suggested improvements (4)
On-demand eval run. Re-runs update this comment in place. |
prvn
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI guard hook and test-skill.sh flagged manual app scaffolding with
mkdir.*(api-integrations|workflows|...), matched against the whole command line. A chained command likemkdir -p /tmp/okta-spec && python3 skills/api-integrations/scripts/adapt_spec_for_foundry.py ...tripped it, so the hook gave a false "Manual creation of Foundry app structure" advisory and test-skill.sh counted an anti-pattern that didn't happen. That accounted for both anti-patterns in a recent A/B baseline. Both patterns now stop at;,&, or|, so only the mkdir's own arguments count. test-hooks.sh adds a case for the chained false positive and one confirmingcd my-app && mkdir -p workflowsstill gets the advisory.A few skill files also called the foundry-sample repos "production" apps, and the workflows skill said its standard trigger + actions format is used by "all" of them. The samples show developers how to use each building block, so the wording now says "many Foundry sample apps" in workflows-development and "12 Foundry sample apps" in api-integrations.