🐛 let the About page scroll so the app name and version are not squeezed out - #5053
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop About page showed only the logo above the Resources card. The app name, version line and the GitHub / X / website buttons were missing, while the mobile About page shows "CrossPaste" and "Version 2.2.1 (126800)" under the logo.
The text was never removed. The brand block took the leftover height with
weight(1f), and on the 700dp main window the Resources and Support cards plus the footer left it roughly 100dp.Columnmeasures children in order with the remaining space, so the 72dp logo and the 16dp spacer consumed it and the name, version and social row were measured down to zero height.Change
verticalScroll) instead of relying on the brand block absorbing leftover space.weight(1f)+ centered arrangement, so it always lays out at its natural height.No copy changes: the version line already uses
AppInfo.displayVersion(), which renders the same2.2.1 (126800)format as mobile.Verification
./gradlew app:compileKotlinDesktoppasses.