Repository navigation
Capture local multiplayer commands and expose replay gaps (0.13.0) - #16
Open
Krarilotus wants to merge 19 commits into
Open
Krarilotus wants to merge 19 commits into
Krarilotus wants to merge 19 commits into
Conversation
Author
|
Published test build for commit Download recorder-0.13.0.zip | Release and checksum Publish workflow succeeded. Verified the downloaded SHA-256 and all 40 packaged files against this exact PR commit. Includes the prior single-player fixes and the new opt-in multiplayer diagnostics; multiplayer recording/playback remains disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Capture multiplayer commands issued by the local player as well as commands received from peers. Make diagnostics check player ownership and explicitly flag immediate commands, roster changes and resync phases that the current replay path cannot yet reproduce.
Release 0.13.0 closes the local-send observation gap: native local commands enter the ring directly and never traverse the existing receive-copy hook. Three opt-in native observers retain the original instructions while recording local timed payloads and detecting local/remote immediate execution. Diagnostic failures do not change commands, registers, RNG or pause state.
Trace format 4 includes the native eight-slot roster and transport mapping. The comparator checks each command's logical actor against that peer's roster, supports transport-handle renumbering between peers, and rejects missing/ambiguous identity, different AI rosters, captures beginning in resync and coverage-gap events. Roster/sync transitions are observed between periodic checkpoints too. Older paired formats remain supported with their original evidence limits.
Includes prior stages. Review this stage against PR #15: Krarilotus/ucp_recorder@fix/live-replay-validation...feat/multiplayer-boundary-evidence.
Validation: 112 automated tests pass, including local-queue payloads, ownership, roster differences, immediate dispatch, hook conflicts, resync transitions and logging-failure pass-through. Original hook bytes pass for Crusader and Extreme; the ZIP builds successfully. Version/changelog and diagnostic instructions are updated. The publish-release workflow will be triggered explicitly for this PR.
This is diagnostic coverage, not multiplayer recording/playback. No live multiplayer test was performed. Immediate payload replay, DirectPlay system-event logging, synchronized starting snapshots, offline roster restoration, host migration, resync reconstruction and extension private state remain outstanding. The conservative gap policy can reject harmless immediate commands too; it does not silently assume a whitelist. Full RNG/resource agreement is not a full-world equality proof.
Native ownership and network-flow analysis is contributed separately in sourcehold/OpenSHC#220. Single-player simulation profile remains
recorder-sp-v6, including PR #15's still-pending final live music-fix validation.