Repository navigation
Conversation
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 179 calls · 4.6M tokens · 92% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
sernote
marked this pull request as ready for review
October 26, 2026 20:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
OpenAI-compatible requests silently lost
prompt_cache_keyandprompt_cache_optionsduring request validation, before reaching LiteLLM. Explicit cache mode and request TTL therefore never reached the selected provider.Declare the optional key and typed options in the request schema. Preserve supplied members without inserting defaults; reject invalid mode/TTL values. This covers blocking and streaming Chat Completions.
prompt_cache_retentionis outside this change.Validation: 831 tests passed in the offline Python 3.12 suite. Regressions exercise the HTTP route, schema, Orca adapter, real LiteLLM Router and OpenAI SDK through HTTP MockTransport. Independent review ran 43 targeted tests, including additional invalid-input and serialized-payload checks. Ruff and
git diff --checkpassed. No live provider cache hit or savings claim.Discovered during a repository audit using audit-prompt-caching, then independently reproduced and reviewed.