Skip to content

Fix VivHelper/FrostHelper not being recognized properly - #113

Open
strandsofivy wants to merge 1 commit into
CommunalHelper:devfrom
strandsofivy:fix-load-order-bugs
Open

Fix VivHelper/FrostHelper not being recognized properly#113
strandsofivy wants to merge 1 commit into
CommunalHelper:devfrom
strandsofivy:fix-load-order-bugs

Conversation

@strandsofivy

Copy link
Copy Markdown

There is a rare load order bug with vivhelper/frosthelper handling in crystallinehelper, namely that vitmod will sometimes treat as if both are not present even though they are. This is because Load() is called immediately after a module is loaded, despite the docs saying it gets called after all mods are loaded. Therefore since optional mods can load at any time even after a mod has been loaded and DependencyLoaded() does not account for this, its incorrect to check for the presence of optional mods during Load() time

Initialize() however is called after all mods have been loaded and the game is initializing, so DependencyLoaded() will give expected results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant