Fix VivHelper/FrostHelper not being recognized properly - #113
Open
strandsofivy wants to merge 1 commit into
Open
Fix VivHelper/FrostHelper not being recognized properly#113strandsofivy wants to merge 1 commit into
strandsofivy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a rare load order bug with vivhelper/frosthelper handling in crystallinehelper, namely that vitmod will sometimes treat as if both are not present even though they are. This is because Load() is called immediately after a module is loaded, despite the docs saying it gets called after all mods are loaded. Therefore since optional mods can load at any time even after a mod has been loaded and DependencyLoaded() does not account for this, its incorrect to check for the presence of optional mods during Load() time
Initialize() however is called after all mods have been loaded and the game is initializing, so DependencyLoaded() will give expected results