Repository navigation
test: stop the permutation-selection contract test failing on a slow vitest list - #301
Merged
Merged
Conversation
…imeout, not a 10 s budget Under machine load the cold vitest list collection exceeded 10 s, the child was killed with status null, and the scheduling-contract test failed though the contract held (it passes alone on the same tree). Raise the kill to 60 s, size the test timeout to match, and assert no spawn error first so a real kill reads as a timeout.
github-actions
Bot
added
the
risk:R1
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 47 minutes for your next included review. View limit details
|
jaeone94
approved these changes
Nov 2, 2026
jaeone94
left a comment
jaeone94
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The 60s kill is now only a hang guard, and checking result.error first means a real kill reads as a timeout, not a contract failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/permutation-selection.test.tsspawnsvitest listwith a 10 s kill. On a loaded machine the cold collection took longer, the child was killed (status: null), and "test selects both representative cases, and only those cases" failed during a fullnpm test, though it passes alone on the same tree. The contract was fine; the budget was not.result.erroris undefined first, so a real kill now reads as a timeout instead of a contract failure.Test-only; no package code changes.
npx vitest run test/permutation-selection.test.ts,lintandtypecheckpass.