Skip to content

London | 26-ITP-Sep | Alan Mak | Sprint 1 | Form Controls - #1515

Open
AlanGit-debug2604 wants to merge 4 commits into
CodeYourFuture:mainfrom
AlanGit-debug2604:feature/form-controls
Open

London | 26-ITP-Sep | Alan Mak | Sprint 1 | Form Controls#1515
AlanGit-debug2604 wants to merge 4 commits into
CodeYourFuture:mainfrom
AlanGit-debug2604:feature/form-controls

Conversation

@AlanGit-debug2604

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1004

Changelist

Create a T-shirt order form. Included required name (regex-validated), email, colour (radio group, 3 options), and size (dropdown, 6 options). Verified negative/positive validation paths. Lighthouse accessibility score 100, W3C validator shows no errors or warnings.

Questions

  1. Whether radios need "required" on all three or just one?
  2. Whether was the right choice for Size vs. 6 radio buttons? In validator, outcome list saying : "Info: Trailing slash on void elements [has no effect]", then quote a piece of code, e.g. ↩ ↩
    Why those outcomes happen and what they are after?

@netlify

netlify Bot commented Sep 13, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 506f217
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aa6bc0198e7210008fa93ae
😎 Deploy Preview https://deploy-preview-1515--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@AlanGit-debug2604 AlanGit-debug2604 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant