Fix direction values in template for Go migrations - #38
Conversation
Change `strings.ToTitle` func by `strings.Title` because it's returns the wanted outcome
69eda06 to
36e6932
Compare
|
Can anybody review the PR? |
|
@ifraixedes I'm not sure if this repo is being maintained anymore but this fix exists in this version of the project https://github.com/steinbacher/goose/blob/master/migration_go.go |
|
@zabawaba99 I could run that fork, using the same command that I use to run the migrations with this fork, I got |
|
@ifraixedes that's right, I forgot about some difference between the projects. You would need to alter your yaml configuration to use Old: driver: postgres
open: user=liam dbname=tester sslmode=disableCurrent: driver: postgres
dsn: user=liam dbname=tester sslmode=disable |
|
@zabawaba99 thanks, I cannot take a look know, I may try the following days, we have to move forward with several things, so for now we disabled the CI |
|
@zabawaba99 I wanted to confirm that your fork works. |
Having a
Gomigration I realized that they don't work with this fork meanwhile they worked with the original repo; the go file generated doesn't compile.I also found that
strings.ToTitledoesn't return the wanted outcome meanwhilestrings.Titledoes.This PR fix the 2 issues.