Skip to content

Use CompressionError for an unknown codec in ORC #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PedroTadim merged 1 commit into from
Sep 24, 2026
Merged

Use CompressionError for an unknown codec in ORC #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion c++/src/Compression.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,9 +1313,12 @@ namespace orc {
return std::make_unique<ZSTDDecompressionStream>(std::move(input), blockSize, pool,
metrics);
default: {
// The codec is read from the file's postscript, so an unknown value is untrusted input
// rather than an internal error. NotImplementedYet derives from std::logic_error, which a
// caller may treat as a failed assertion and abort on, so reject it with a runtime_error.
std::ostringstream buffer;
buffer << "Unknown compression codec " << kind;
throw NotImplementedYet(buffer.str());
throw CompressionError(buffer.str());
}
}
}
Expand Down
Loading