Observed
appendRowsBlocks may return nil even if an error happened.
in our project we use Append with blocks, so it's getting into the appendRowsBlocks codepath. We observe incomplete streams being appended without errors.
Expected behaviour
Return error if a mid-stream error happens in the appendRowsBlocks codepath.
In
|
func (b *batch) appendRowsBlocks(r *rows) error { |
when returning after looping on r.Next()
return r.Err() instead of nil.
Observed
appendRowsBlocks may return nil even if an error happened.
in our project we use Append with blocks, so it's getting into the appendRowsBlocks codepath. We observe incomplete streams being appended without errors.
Expected behaviour
Return error if a mid-stream error happens in the appendRowsBlocks codepath.
In
clickhouse-go/conn_batch.go
Line 138 in a1ee16b
when returning after looping on r.Next()
clickhouse-go/conn_batch.go
Line 162 in a1ee16b
return
r.Err()instead ofnil.