Skip to content

Update CODEOWNERS to reflect new team structure - #3589

Merged
kodiakhq[bot] merged 1 commit into
mainfrom
teeohhem-patch-1
Nov 6, 2026
Merged

kodiakhq[bot] merged 1 commit into
mainfrom
teeohhem-patch-1

Conversation

@teeohhem

@teeohhem teeohhem commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Screenshots or video

Before After

How to reproduce

Starting point:

On main:

On this branch:

How to test on Vercel preview

Preview routes:

Steps:

References

  • Linear Issue:
  • Related PRs:

@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
clickstack-oss Ignored Ignored Nov 6, 2026 10:26pm UTC
clickstack-storybook Ignored Ignored Nov 6, 2026 10:26pm UTC

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 2
  • Branch: teeohhem-patch-1
  • Author: teeohhem

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 110 in total (1.21%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This PR changes a single line in .github/CODEOWNERS, renaming the catch-all owning team from @ClickHouse/clickstack-app-devs to @ClickHouse/clickstack. The entry is syntactically valid (* catch-all + well-formed @org/team owner), and a repo-wide search found no other files referencing the old handle, so the rename is self-contained and leaves no dangling references.

🟡 P2 -- recommended

  • .github/CODEOWNERS:2 -- The rename takes effect only if @ClickHouse/clickstack exists under the org and has write access; otherwise GitHub silently ignores the rule and auto-requests no reviewers, with no error surfaced in the file.
    • Fix: Confirm in the org's team settings that @ClickHouse/clickstack exists and holds write access to this repository before merging.

Reviewers (3): correctness, project-standards, previous-comments.

Testing gaps: CODEOWNERS owner resolution is validated only by GitHub's external linting (repo Settings), not by anything in this diff.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@kodiakhq
kodiakhq Bot merged commit ab3b786 into main Nov 6, 2026
33 checks passed
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 462 passed • 1 skipped • 1182s

Status Count
✅ Passed 462
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq
kodiakhq Bot deleted the teeohhem-patch-1 branch November 6, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants