Skip to content

test(api): reproduce raw SQL Number alert catch-up over-counting - #3577

Draft
tommyzli wants to merge 1 commit into
mainfrom
claude/raw-sql-number-alert-catchup-test
Draft

tommyzli wants to merge 1 commit into
mainfrom
claude/raw-sql-number-alert-catchup-test

Conversation

@tommyzli

@tommyzli tommyzli commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

After a missed tick the next evaluation's date range extends back to the last evaluated window. Time-series alerts bucket that range per interval, but raw SQL Number tile alerts run their SQL once over the whole range and compare the multi-window total against the per-window threshold, so a count alert can fire when no single window breached.

This test fails on main (received [4], expected [2, 2]) and passes once single-value evaluations are scoped per window.

Repro of #3578

Screenshots or video

Before After

How to reproduce

Starting point:

On main:

On this branch:

How to test on Vercel preview

Preview routes:

Steps:

References

  • Linear Issue:
  • Related PRs:

After a missed tick the next evaluation's date range extends back to the
last evaluated window. Time-series alerts bucket that range per interval,
but raw SQL Number tile alerts run their SQL once over the whole range and
compare the multi-window total against the per-window threshold, so a
count alert can fire when no single window breached.

This test fails on main (received [4], expected [2, 2]) and passes once
single-value evaluations are scoped per window.
@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a1eef06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Nov 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 5, 2026 11:35pm UTC
hyperdx-storybook Ready Ready Preview Nov 5, 2026 11:35pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 110 in total (1.22%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 461 passed • 1 skipped • 1347s

Status Count
✅ Passed 461
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — a1eef068 Deployed Nov 5, 2026 by vercel[bot]
Preview – hyperdx-storybook — a1eef068 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant