hp_proliant_da_cntlr: do not discover phantom controllers#929
Open
Bastian-Kuhn wants to merge 1 commit into
Open
hp_proliant_da_cntlr: do not discover phantom controllers#929Bastian-Kuhn wants to merge 1 commit into
Bastian-Kuhn wants to merge 1 commit into
Conversation
Bastian-Kuhn
force-pushed
the
fix-hp-proliant-da-cntlr-phantom-discovery
branch
from
20e0023 to
425517a
Compare
The controller table (cpqDaCntlrTable) on HPE ProLiant Gen11 / iLO 6 contains a
placeholder row -- typically index 0 -- whose condition, role, board status and
board condition cells are all '0', a value the vendor MIB does not define.
parse_hp_proliant_da_cntlr already parses such rows to None, but discovery
iterated over all section keys and still created a service for the phantom row,
which was then permanently UNKNOWN ('Controller not found in SNMP data').
Discovery now skips None entries.
Bastian-Kuhn
force-pushed
the
fix-hp-proliant-da-cntlr-phantom-discovery
branch
from
425517a to
f9e3778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hp_proliant_da_cntlrno longer discovers phantom controllers.Why
On HPE ProLiant Gen11 / iLO 6 the controller table (
cpqDaCntlrTable) contains a placeholder row — typically index 0 — whose condition/role/board‑status/board‑condition cells are all0(a value the vendor MIB does not define).parse_hp_proliant_da_cntlralready parses such rows toNone, butdiscovery_hp_proliant_da_cntlriterated over all section keys and still discovered the phantom item, whose service was then permanentlyUNKNOWN("Controller not found in SNMP data").