Repository navigation
Conversation
The github-actions branch no longer exists, so the one thing this entry can still do is run the suite twice for any branch that happens to be named github-actions -- once for the push and once for its pull request. Pull requests are already covered by the pull_request trigger, so limiting push to the trunk leaves every branch tested exactly once before it lands.
The matrix includes Active Record's main and *-stable branches, which move without anything happening in this repository, so a break in an unreleased Active Record only surfaces on the next push here -- possibly months later. A weekly run surfaces it while the change is still fresh upstream. workflow_dispatch comes along so the same suite can be started by hand without an empty commit.
The badge image is already pinned to master, but clicking it landed on the workflow's unfiltered run list, where a pull request's run is usually the first thing shown -- so a green badge could lead to a red run for a branch that had not merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small CI housekeeping changes, one commit each.
Only run CI on pushes to master. The push trigger also listed a
github-actionsbranch that no longer exists, so the only thing it couldstill do was run the suite twice for a branch by that name — once for the
push and once for its pull request.
Run CI every week (
schedule, Saturdays 18:00 UTC, plusworkflow_dispatch). The matrix includes Active Record'smainand*-stablebranches, which move without anything happening here, so a breakin an unreleased Active Record currently waits for the next push to this
repository to surface. A weekly run catches it while the upstream change is
still fresh.
Link the build badge to master's runs. The badge image was already
pinned with
?branch=master, but its link went to the workflow'sunfiltered run list, where a pull request's run is usually the first thing
shown — so a green badge could lead to a red run for an unmerged branch.
The link now carries
?query=branch%3Amasterto match the image.Two pre-existing nits in
ci.ymlare left alone here, happy to take eitherin a follow-up:
actions/checkout@v3is old enough that GitHub warns aboutits Node runtime, and the
steps:entries are indented two spaces short ofwhat yamllint wants.