Fix reversal potential inference and docstring for detect_ramp_bounds#100
Merged
Conversation
added 12 commits
November 6, 2025 11:18
…cpostprocess into js_fix_infer_reversal
joeyshuttleworth
commented
Nov 6, 2025
Collaborator
Author
There was a problem hiding this comment.
Parameter name was a bit confusing here
joeyshuttleworth
commented
Nov 6, 2025
Collaborator
Author
There was a problem hiding this comment.
These lines were causing infer reversal potential to fail for every single trace
MichaelClerx
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix reversal potential inference due to a mismatch in what is returned from detect_ramp_bounds. Update/correct detect_ramp_bounds docstring and variable/parameter names. Closes #99.
Includes new test for infer_reversal_potential().
Types of changes
Testing
Documentation checklist