Fix/11167: Revamped input handling Android fix - #11647
Merged
kevlahnota merged 6 commits intoAug 21, 2026
Merged
Conversation
Everything works for the player animations are jittery on controller now. haven't tested mobile either but mouse works. (cherry picked from commit f28811a)
Still not tested on mobile but will do later. (Should be the same as mouse input) (cherry picked from commit b260851)
(cherry picked from commit 467ab52)
(cherry picked from commit 82714d1)
Added helper function to KeyBinding.java for getting pressed key from libGDX (cherry picked from commit a631d4f)
Jetz72
requested review from
kevlahnota and
tehdiplomat
and removed request for
tehdiplomat
August 20, 2026 14:33
kevlahnota
approved these changes
Aug 21, 2026
kevlahnota
left a comment
kevlahnota
left a comment
Contributor
There was a problem hiding this comment.
seems to work fine ty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from: Archipelago PR
Builds further on the groundwork laid in this PR
Fixes an issue found in this PR which was reverted.
An issue was found with my previous PR (linked above) that was causing players not to be able to move correctly, enter POIs or enter battles on Android. At the time, I was not able to build the Android version of the app locally so I couldn't test the platform, that's now been resolved and I was able to reproduce the observed issue as well as fix it.
It turns out Android movement input is handled by a different mechanism compared to desktops, namely the
touchPadand more accurately itsknobmember.In this PR I have fixed the issues described above as well as re-staged the commits reverted earlier that improve input handling. Only the changes made from 22327ec on out should be reviewed as everything before that has already been looked at in the abovementioned PR.
Android input bugfix
touchKnobInputinput vector toGameStage.javaGameHUD.java's touchpad listener so it reports player input to the newtouchKnobInputvector inGameStage.javatouchKnobInputto the input priority ranking created in the reverted PR above such that the priority is: mouse/touch > controller > touchKnob > keyboard.