Skip to content

fix[smartling]: ENG-12342 fix 'Clear translation metadata' button not working #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manish-Builder-io wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −7
Open

fix[smartling]: ENG-12342 fix 'Clear translation metadata' button not working #4544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31154a1
fix[smartling]: fix Clear translation metadata button not working
Manish-Builder-io Apr 28, 2026
acf6943
fix[smartling]: pass string to dialogs.confirm instead of object
Manish-Builder-io Jul 14, 2026
f11e7e6
fix[smartling]: restore guarded metadata conversion
sanyamkamat Jul 14, 2026
55e4f7b
fix[smartling]: update version to 0.1.2-0 in package.json and package…
sanyamkamat Jul 14, 2026
e3a9e11
fix[smartling]: update version to 0.1.2-1 in package.json and package…
sanyamkamat Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/smartling/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/smartling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/plugin-smartling",
"version": "0.1.1",
"version": "0.1.2-1",
"description": "",
"keywords": [],
"main": "dist/plugin.system.js",
Expand Down
9 changes: 5 additions & 4 deletions plugins/smartling/src/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,11 +848,12 @@ const initializeSmartlingPlugin = async () => {
);
},
async onClick(content) {
const result = await appState.dialogs.confirm({
message: 'This will clear all translation metadata from this content. Are you sure?',
});
const result = await appState.dialogs.confirm(
'This will clear all translation metadata from this content. Are you sure?'
);
if (result) {
const updatedMeta = fastClone(content.meta);
const metadata = typeof content.meta?.toJS === 'function' ? content.meta.toJS() : content.meta;
const updatedMeta = { ...(metadata || {}) };
delete updatedMeta.translationStatus;
delete updatedMeta.translationJobId;
delete updatedMeta.translationBy;
Expand Down
Loading