Repository navigation
fix(touch): avoid FT6X36 reset on every read and harden brightness menu - #3115
Merged
bmorcelli merged 1 commit intoNov 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Generic fixes split out from #3073; the Freenove board changes stay in #3073.
touch.cpp: do not calltouch.reset()on every FT6X36 read. It toggles the hardware RST pin (30 ms low + 160 ms release) on every sample, making drags ~190 ms per sample and occasionally leaving the controller wedged. ReadingFT6X36_REG_STATUSalready clears the interrupt/point latch.settings.cpp: clamp brightness to >=1 (a saved 0 leaves the screen dark with no visible UI to raise it) and disable the body touch zone while the brightness menu is open (the slider sits inside theSelPresszone).These are not board-specific.
Verification
Hardware-tested on Freenove FNK0104AB as part of #3073 (touch drag, brightness menu, config save).
Rebased on current
dev@fa6bcbf3:ES3C28Pregression build: PASS locally.Freenove-FNK0104ABbuild: PASS locally with the combined v0.1.2 validation build.User-Facing Change