Repository navigation
Count sockets by number when balancing column heights - #268
Merged
Merged
Conversation
Hashing the Socket dataclass was most of the cost of each candidate move. Layouts are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Merging this PR will improve performance by ×2.2
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_arrange_decoder_4bit[sugiyama] |
5.3 s | 2.4 s | ×2.2 |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing balance-socket-ids (6e78b4d) with main (3f0481c)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 105 105
Lines 31104 31106 +2
=======================================
+ Hits 30575 30577 +2
Misses 529 529 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BradyAJohnston
added a commit
that referenced
this pull request
Oct 12, 2026
Hashing the Socket dataclass was most of the cost of each candidate move. Layouts are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The balancing search hashed the `Socket` dataclass for every candidate move, which was most of `arrange`'s time on the decoder benchmark. Sockets are now numbered once per search.
`test_arrange_decoder_4bit[sugiyama]` locally: 0.20 s → 0.09 s. Layouts unchanged (corpus snapshots pass). This also covers the regression in #254, which gives the search more to do.