Repository navigation
Start Voronoi Texture 2D in the compositor - #257
Merged
Merged
Conversation
Like Noise Texture, Voronoi starts 2D in the compositor and 3D elsewhere, and one class serves both trees, so the constructor forced 3D. Leave voronoi_dimensions to Blender unless passed. The constructor parity test now compares enums as well, so other tree-dependent defaults are caught. Menu Switch's data_type is excluded: nodebpy defaults it to FLOAT and takes the type from the factory.
Contributor
BradyAJohnston
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c.VoronoiTexture()came out 3D, while Blender starts it 2D in the compositor (3D elsewhere). This is the same issue #256 fixed for Noise Texture, found by comparing against the tree-dependent properties listed in blender#163306.voronoi_dimensionsis now left to Blender unless passed.The constructor parity test now also compares enums in every tree type, so this kind of mismatch is caught. Menu Switch
data_typeis excluded on purpose: it defaults to FLOAT and takes its type from the factory (g.MenuSwitch.float(...)).Bumps to 520.35.1.