Skip to content

Emit menu interface defaults inline in exported code - #250

Merged
BradyAJohnston merged 1 commit into
mainfrom
fix/menu-default-inline
Oct 7, 2026
Merged

BradyAJohnston merged 1 commit into
mainfrom
fix/menu-default-inline

Conversation

@BradyAJohnston

Copy link
Copy Markdown
Owner

The exporter wrote menu interface defaults as a trailing var.default_value = ... after the tree body. The builder already defers menu defaults to context exit, so they can be passed at creation: tree.inputs.menu("Menu", "Tetrahedral").

Removes the exporter's deferral plumbing and bumps to 520.34.1.

@BradyAJohnston BradyAJohnston changed the title Emit menu interface defaults inline in exported code (520.34.1) Emit menu interface defaults inline in exported code Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.30%. Comparing base (1d5aed1) to head (6c37abd).

Files with missing lines Patch % Lines
src/nodebpy/export/codegen.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         101      101              
  Lines       30565    30556       -9     
==========================================
- Hits        30048    30039       -9     
  Misses        517      517              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BradyAJohnston
BradyAJohnston merged commit 520eada into main Oct 7, 2026
8 of 9 checks passed
@BradyAJohnston
BradyAJohnston deleted the fix/menu-default-inline branch October 7, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant