ADD: redacted push notifications#329
Conversation
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Privacy opt-in feature: TokenConfiguration.redacted strips FCM/APNS alert text and data at send time. Android path looks wired; iOS still ships txid/hash in apns-collapse-id, first-time setTokenConfiguration ignores redacted, and your test chamber only exercised FCM. Cake was a lie; redaction is half-baked.
Inline findings (could not anchor on diff)
src/class/GroundControlToMajorTom.ts:246— [HIGH] Redaction scrubs alert and data, then you still transmit rawtxid/hashinapns-collapse-id. Privacy theater on iOS — Apple gets the secret you promised to hide.src/controller/GroundController.ts:259— [MEDIUM] New token branch setstoken/osonly;body.redactedis ignored on firstsetTokenConfiguration. Opt-in privacy silently stays false until a second call. Congratulations, you built a two-step puzzle.src/tests/GroundController.test.ts:384— [MEDIUM] NewredactedAPI field, no set/get coverage. Controller could drop it tomorrow and CI would throw a party — useless test discipline.
5b00161 to
8594342
Compare
|
@Overtorment can you please check ? |
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Privacy feature, incomplete test chamber. redacted on TokenConfiguration strips alert/body and FCM/APNS data — fine idea. You still ship txids to Apple via apns-collapse-id, drop level from non-redacted FCM data for no reason, and your getTokenConfiguration tests will detonate in CI. The APNS test swallows errors like a cooperative test subject. CONTRIBUTING.md? Another missing file. Shocking.
Inline findings (could not anchor on diff)
src/class/GroundControlToMajorTom.ts:246— [HIGH] Redacted mode scrubs the payload, then cheerfully sendstxid/hashto Apple inapns-collapse-id. Privacy theater. Use a generic collapse id when redacted.src/tests/GroundController.test.ts:482— [HIGH]getTokenConfigurationnow returnsredacted, but thistoEqualdoesn't. CI will fail. Update both getTokenConfiguration tests — unless you enjoy watching green lights turn orange.src/tests/GroundController.test.ts:384— [HIGH] NewredactedAPI field: zero persistence or round-trip tests. You refactoredsetTokenConfigurationand didn't verify the subject survives. Science demands better subjects.
Adds a "Redact notification content" toggle to Notification Settings. When enabled, GroundControl sends generic push text with no transaction data, so payment details never appear on the lock screen or in the notification payload. depends on BlueWallet/GroundControl#329 closes BlueWallet#8499
Adds a redacted flag to TokenConfiguration so a device can opt into. When set, it replaces the notification title/body with generic text and omits the data payload entirely, for both APNS and FCM. related: BlueWallet/BlueWallet#8499
Adds a redacted flag to TokenConfiguration so a device can opt into. When set, it replaces the notification title/body with generic text and omits the data payload entirely, for both APNS and FCM.
related: BlueWallet/BlueWallet#8499