Repository navigation
avoid signed left-shift overflow in blosclz byte readers - #410
Open
suraiya-ctrl wants to merge 1 commit into
Open
suraiya-ctrl wants to merge 1 commit into
suraiya-ctrl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On strict-alignment targets the blosclz byte readers overflow a signed int:
BLOSC_STRICT_ALIGNstays defined on ARM (Apple Silicon, Graviton), RISC-V and every non-x86/non-PPC build, so those platforms use the macro variant inblosclz.cBLOSCLZ_READU32evaluates(p)[3]<<24; the byte promotes toint, so the shift lands in the sign bit whenever the fourth byte is >= 0x80, which is signed-integer overflow (UB)blosclz_compressandget_cratio, so real data trips it on almost every blockUBSan on a plain compress of ordinary data:
Casting each byte to
uint32_tkeeps the shifts unsigned and yields the same value the non-strict*(const uint32_t*)fast path already returns. UBSan is clean after the change and the full ctest suite passes on arm64 (the strict-align path).